-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Avatar) replace border with isBordered #571
feat(Avatar) replace border with isBordered #571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good (missing blank lines at the end of the files so I'm guessing you might want to run prettier on all of them, that's not blocking though).
One big question though: do you know what the deal is with all the yarn.lock changes? Seems odd when there is no package file change here.
Hmm, let me investigate that |
7a09cb5
to
7b1b30b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments below, lmk what you think!
...demods/src/rules/v6/avatarReplaceBorderForIsBordered/avatar-replace-border-for-isBordered.md
Outdated
Show resolved
Hide resolved
...demods/src/rules/v6/avatarReplaceBorderForIsBordered/avatar-replace-border-for-isBordered.md
Outdated
Show resolved
Hide resolved
...demods/src/rules/v6/avatarReplaceBorderForIsBordered/avatar-replace-border-for-isBordered.ts
Show resolved
Hide resolved
8d0f1c8
to
abef321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than yarn lock issue
abef321
to
5683868
Compare
closes #549